fix: remove doubled words in error/warning messages - #15949
Open
andrewwhitecdw wants to merge 9 commits into
Open
fix: remove doubled words in error/warning messages#15949andrewwhitecdw wants to merge 9 commits into
andrewwhitecdw wants to merge 9 commits into
Conversation
Member
|
/claude review |
Author
|
Could a maintainer please add the |
Member
|
remove test |
svcnvidia-nemo-ci
added
the
waiting-on-customer
nithinraok
approved these changes
Jul 28, 2026
Member
|
signoff your commits |
Signed-off-by: Andrew White <andrewh@cdw.com>
Signed-off-by: Andrew White <andrewh@cdw.com>
Signed-off-by: lilithgrigoryan <lgrigoryan@nvidia.com> Signed-off-by: Andrew White <andrewh@cdw.com>
* update TTS tutorials Signed-off-by: Jason <jasoli@nvidia.com> * remove old assets Signed-off-by: Jason <jasoli@nvidia.com> --------- Signed-off-by: Jason <jasoli@nvidia.com> Signed-off-by: Andrew White <andrewh@cdw.com>
Signed-off-by: Jason <jasoli@nvidia.com> Signed-off-by: Andrew White <andrewh@cdw.com>
…local ResidualMLP (NVIDIA-NeMo#15959) * fix Signed-off-by: lilithgrigoryan <lgrigoryan@nvidia.com> * fix Signed-off-by: lilithgrigoryan <lgrigoryan@nvidia.com> --------- Signed-off-by: lilithgrigoryan <lgrigoryan@nvidia.com> Signed-off-by: Andrew White <andrewh@cdw.com>
Signed-off-by: Dongji Gao <dongjig@nvidia.com> Signed-off-by: Andrew White <andrewh@cdw.com>
…onfigKeyError (NVIDIA-NeMo#15964) * add confidences to beam search + cache_aware in streaming inference Signed-off-by: lilithgrigoryan <lgrigoryan@nvidia.com> * clean up Signed-off-by: lilithgrigoryan <lgrigoryan@nvidia.com> * add logging frame confidence Signed-off-by: lilithgrigoryan <lgrigoryan@nvidia.com> * clean up Signed-off-by: lilithgrigoryan <lgrigoryan@nvidia.com> * clean up Signed-off-by: lilithgrigoryan <lgrigoryan@nvidia.com> * minor clean up Signed-off-by: lilithgrigoryan <lgrigoryan@nvidia.com> * clean uo Signed-off-by: lilithgrigoryan <lgrigoryan@nvidia.com> * minor changes Signed-off-by: lilithgrigoryan <lgrigoryan@nvidia.com> * fix tests Signed-off-by: lilithgrigoryan <lgrigoryan@nvidia.com> * minor fix Signed-off-by: lilithgrigoryan <lgrigoryan@nvidia.com> * revert compute_metrics_per_sample argument Signed-off-by: lilithgrigoryan <lgrigoryan@nvidia.com> * fix Signed-off-by: lilithgrigoryan <lgrigoryan@nvidia.com> * fix preprocessor Signed-off-by: lilithgrigoryan <lgrigoryan@nvidia.com> * clean up Signed-off-by: lilithgrigoryan <lgrigoryan@nvidia.com> --------- Signed-off-by: lilithgrigoryan <lgrigoryan@nvidia.com> Signed-off-by: Andrew White <andrewh@cdw.com>
…VIDIA-NeMo#15797) (NVIDIA-NeMo#15932) * fix(asr): make DynamicLengthTensor indexing Python 3.10-compatible (NVIDIA-NeMo#15797) `streaming_utils.py` used a PEP 646 starred expression directly inside a subscript (`x[..., *[None for _ in ...]]`), which only parses on Python 3.11+. On Python 3.10 -- which NeMo officially supports (`requires-python = ">=3.10"`) -- importing the module raised a SyntaxError, breaking cache-aware streaming inference. Build the index tuple explicitly (`x[(..., *(None for _ in ...))]`), which uses standard tuple iterable-unpacking (valid since 3.5) and is semantically identical to the original indexing across all dim_shape lengths. Verified to compile on CPython 3.10 through 3.15. Fixes NVIDIA-NeMo#15797 Signed-off-by: Gaurav Chaudhari <107786677+gauravbyte@users.noreply.github.com> Co-authored-by: Cursor <cursoragent@cursor.com> * chore(asr): drop comments around Python 3.10 indexing fix Signed-off-by: Gaurav Chaudhari <107786677+gauravbyte@users.noreply.github.com> Co-authored-by: Cursor <cursoragent@cursor.com> * chore(asr): restore original trailing-axes comment Signed-off-by: Gaurav Chaudhari <107786677+gauravbyte@users.noreply.github.com> Co-authored-by: Cursor <cursoragent@cursor.com> --------- Signed-off-by: Gaurav Chaudhari <107786677+gauravbyte@users.noreply.github.com> Co-authored-by: Cursor <cursoragent@cursor.com> Co-authored-by: Nithin Rao <nithinrao.koluguri@gmail.com> Signed-off-by: Andrew White <andrewh@cdw.com>
andrewwhitecdw
force-pushed
the
fix-doubled-words-error-messages
branch
from
July 29, 2026 00:02
feb42a6 to
f5d9c7c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes two user-facing doubled-word typos in error/warning messages.\n\n-
nemo/core/optim/lr_scheduler.py: 'max_stepsis not not provided' → 'max_stepsis not provided'\n-nemo/collections/asr/modules/conformer_encoder.py: '... is not not a valid value' → '... is not a valid value'\n\ncc @nithinraok for core/ASR review